Hi Sergei,
Thanks for the feedback.
> Subject: Re: [PATCH net-next v2 7/8] ravb: Add internal delay hw feature
> to struct ravb_hw_info
>
> On 8/2/21 1:26 PM, Biju Das wrote:
>
> > R-Car Gen3 supports TX and RX clock internal delay modes, whereas
> > R-Car
> > Gen2 and RZ/G2L do not support it.
> > Add an internal_delay hw feature bit to struct ravb_hw_info to enable
> > this only for R-Car Gen3.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> [...]
>
> OK, this one also seems uncontroversial:
So far the comments I received
1) I have replaced NUM_TX_DESC to num_tx_desc. But you are recommending to rename it,
is ravb_num_tx_desc good choice?
2) skb_sz to max_rx_len, I am ok for it, if there is no objection from others.
3) patches related to device stats.
I already provided the output of ethtool -S eth0 for both R-Car and RZ/G2L.
For RZ/G2L there is an "rx_queue_0_csum_offload_errors: 0", instead of
"rx_queue_0_missed_errors: 0", Both uses MSC bit 6 for collecting this info.
To provide correct output to the user using command "ethtool -S eth0",
RZ/G2L need to have a different string LUT.
Q1) Do you agree with this?
Cheers,
Biju
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
>
> MBR, Sergei
