Hi Sergei,
> Subject: Re: [PATCH net-next v2 3/8] ravb: Add num_gstat_queue to struct
> ravb_hw_info
>
> On 8/3/21 10:13 PM, Biju Das wrote:
>
> [...]
> >>> The number of queues used in retrieving device stats for R-Car is 2,
> >>> whereas for RZ/G2L it is 1.
> >
> >>
> >> Mhm, how many RX queues are on your platform, 1? Then we don't
> >> need so specific name, just num_rx_queue.
> >
> > There are 2 RX queues, but we provide only device stats information from
> first queue.
> >
> > R-Car = 2x15 = 30 device stats
> > RZ/G2L = 1x15 = 15 device stats.
>
> That's pretty strange... how the RX queue #1 is called? How many RX
> queues are, at all?
For both R-Car and RZ/G2L,
-------------------------
#define NUM_RX_QUEUE 2
#define NUM_TX_QUEUE 2
Target device stat output for RZ/G2L:-
------------------------------------
root@smarc-rzg2l:~# ethtool -S eth0
NIC statistics:
rx_queue_0_current: 21852
tx_queue_0_current: 18854
rx_queue_0_dirty: 21852
tx_queue_0_dirty: 18854
rx_queue_0_packets: 21852
tx_queue_0_packets: 9427
rx_queue_0_bytes: 28224093
tx_queue_0_bytes: 1659438
rx_queue_0_mcast_packets: 498
rx_queue_0_errors: 0
rx_queue_0_crc_errors: 0
rx_queue_0_frame_errors: 0
rx_queue_0_length_errors: 0
rx_queue_0_csum_offload_errors: 0
rx_queue_0_over_errors: 0
root@smarc-rzg2l:~#
Target device stat output for R-Car Gen3:-
----------------------------------------
root@hihope-rzg2m:~# ethtool -S eth0
NIC statistics:
rx_queue_0_current: 34215
tx_queue_0_current: 14158
rx_queue_0_dirty: 34215
tx_queue_0_dirty: 14158
rx_queue_0_packets: 34215
tx_queue_0_packets: 14158
rx_queue_0_bytes: 38313586
tx_queue_0_bytes: 3222182
rx_queue_0_mcast_packets: 499
rx_queue_0_errors: 0
rx_queue_0_crc_errors: 0
rx_queue_0_frame_errors: 0
rx_queue_0_length_errors: 0
rx_queue_0_missed_errors: 0
rx_queue_0_over_errors: 0
rx_queue_1_current: 0
tx_queue_1_current: 0
rx_queue_1_dirty: 0
tx_queue_1_dirty: 0
rx_queue_1_packets: 0
tx_queue_1_packets: 0
rx_queue_1_bytes: 0
tx_queue_1_bytes: 0
rx_queue_1_mcast_packets: 0
rx_queue_1_errors: 0
rx_queue_1_crc_errors: 0
rx_queue_1_frame_errors: 0
rx_queue_1_length_errors: 0
rx_queue_1_missed_errors: 0
rx_queue_1_over_errors: 0
Cheers,
Biju
