Hi Mark and Prabhakar, + Vinod. The first binding patch is for SSI support in interrupt mode. so it is ok. The second binding patch is for adding DMA support in ssi. The example value in #dma-cells need to be updated. Earlier it was just MID/RID value. Based on recent discussion with Vinod and Geert, It needs to updated with encoded values of MID/RID value and legacy channel configuration parameters, as passing the later to driver using slave_config is not recommended. So either drop the second patch or Will send a follow up patch fixing the example + dmas = <&dmac 0x2655>, + <&dmac 0x2656>; Please let me know. Regards, Biju > -----Original Message----- > From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Sent: 30 July 2021 20:13 > To: Mark Brown <broonie@xxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Liam > Girdwood <lgirdwood@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Jaroslav > Kysela <perex@xxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Biju Das > <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>; Chris Brandt > <Chris.Brandt@xxxxxxxxxxx>; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; > Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; > linux-renesas-soc@xxxxxxxxxxxxxxx; Biju Das <biju.das@xxxxxxxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx > Subject: RE: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support > > Hi Mark, > > > -----Original Message----- > > From: Mark Brown <broonie@xxxxxxxxxx> > > Sent: 30 July 2021 20:04 > > To: Takashi Iwai <tiwai@xxxxxxxx>; Liam Girdwood > > <lgirdwood@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Jaroslav > > Kysela <perex@xxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Biju > > Das <biju.das.jz@xxxxxxxxxxxxxx> > > Cc: Mark Brown <broonie@xxxxxxxxxx>; Prabhakar Mahadev Lad > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; > > Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>; Chris Brandt > > <Chris.Brandt@xxxxxxxxxxx>; Chris Paterson > > <Chris.Paterson2@xxxxxxxxxxx>; Geert Uytterhoeven > > <geert+renesas@xxxxxxxxx>; alsa-devel@alsa- project.org; > > linux-renesas-soc@xxxxxxxxxxxxxxx; Biju Das <biju.das@xxxxxxxxxxxxxx>; > > devicetree@xxxxxxxxxxxxxxx > > Subject: Re: (subset) [PATCH v2 0/8] Add RZ/G2L Sound support > > > > On Mon, 19 Jul 2021 14:40:32 +0100, Biju Das wrote: > > > This patch series aims to add ASoC support on RZ/G2L SoC's. > > > > > > It is based on the work done by Chris Brandt for RZ/A ASoC driver. > > > > > > Biju Das (8): > > > ASoC: dt-bindings: Document RZ/G2L bindings > > > sound: soc: sh: Add RZ/G2L SSIF-2 driver > > > arm64: dts: renesas: r9a07g044: Add external audio clock nodes > > > arm64: dts: renesas: r9a07g044: Add SSI support > > > arm64: defconfig: Enable ASoC sound support for RZ/G2L SoC > > > ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support > > > sound: sh: rz-ssi: Add SSI DMAC support > > > arm64: dts: renesas: r9a07g044: Add SSI DMA support > > > > > > [...] > > > > Applied to > > > > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit. > > kernel.org%2Fpub%2Fscm%2Flinux%2 > > Fkernel%2Fgit%2Fbroonie%2Fsound.git&data=04%7C01%7Cprabhakar.mahad > > ev- > > lad.rj%40bp.renesas.com%7C60c047db42e149eacdb808d9538ccc7e%7C53d82571d > > a1947e49cb4625a166a4a2a%7C0%7C0% > > 7C637632686468564246%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI > > joiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > > CI6Mn0%3D%7C1000&sdata=Rdyi2vXY9i%2Fly%2FOTWVFmc8k0rVbpM75FthJn7ri > > jxwU%3D&reserved=0 for-next > > > > Thanks! > > > > [1/8] ASoC: dt-bindings: Document RZ/G2L bindings > > commit: 2b761f476f3a6e0a212c8c88e7855f66edb177e0 > > [6/8] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support > > commit: 5df6dfbb6de815ba3a75c788a916865212fd5221 > > > There is a updated version of the patch [1] which was posted yesterday due > to change in handling DMA slave channel configuration [2]. Both the queued > patches need to dropped. > > [1] https://patchwork.kernel.org/project/linux-renesas- > soc/patch/20210729172311.31111-2-biju.das.jz@xxxxxxxxxxxxxx/ > [2] https://patchwork.kernel.org/project/linux-renesas- > soc/patch/20210729082520.26186-2-biju.das.jz@xxxxxxxxxxxxxx/ > > Cheers, > Prabhakar > > > All being well this means that it will be integrated into the > > linux-next tree (usually sometime in the next 24 hours) and sent to > > Linus during the next merge window (or sooner if it is a bug fix), > however if problems are discovered then the patch may be dropped or > reverted. > > > > You may get further e-mails resulting from automated or manual testing > > and review of the tree, please engage with people reporting problems > > and send followup patches addressing any issues that are reported if > needed. > > > > If any updates are required or you are submitting further changes they > > should be sent as incremental updates against current git, existing > patches will not be replaced. > > > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > > > Thanks, > > Mark
