Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH net-next 02/18] drivers: clk: renesas: rzg2l-cpg: Add
> support to handle MUX clocks
>
> Hi Biju,
>
>
> On Thu, Jul 22, 2021 at 4:14 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Add support to handle mux clocks inorder to select a clock source from
> > multiple sources.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> > --- a/drivers/clk/renesas/rzg2l-cpg.h
> > +++ b/drivers/clk/renesas/rzg2l-cpg.h
> > @@ -43,6 +43,7 @@ struct cpg_core_clk {
> > const struct clk_div_table *dtable;
> > const char * const *parent_names;
> > int flag;
> > + int mux_flags;
> > int num_parents;
> > };
> >
>
> I'd move SEL_PLL_PACK() from [PATCH 03/18] here, as it applies to "_conf"
> in DEF_MUX() below.
OK. Will move in this patch
Regards,
Biju
>
> > @@ -54,6 +55,9 @@ enum clk_types {
> >
> > /* Clock with divider */
> > CLK_TYPE_DIV,
> > +
> > + /* Clock with clock source selector */
> > + CLK_TYPE_MUX,
> > };
> >
> > #define DEF_TYPE(_name, _id, _type...) \ @@ -69,6 +73,11 @@ enum
> > clk_types { #define DEF_DIV(_name, _id, _parent, _conf, _dtable,
> > _flag) \
> > DEF_TYPE(_name, _id, CLK_TYPE_DIV, .conf = _conf, \
> > .parent = _parent, .dtable = _dtable, .flag = _flag)
> > +#define DEF_MUX(_name, _id, _conf, _parent_names, _num_parents, _flag,
> \
> > + _mux_flags) \
> > + DEF_TYPE(_name, _id, CLK_TYPE_MUX, .conf = _conf, \
> > + .parent_names = _parent_names, .num_parents =
> _num_parents, \
> > + .flag = _flag, .mux_flags = _mux_flags)
> >
> > /**
> > * struct rzg2l_mod_clk - Module Clocks definitions
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
