RE: [PATCH v2 2/8] sound: soc: sh: Add RZ/G2L SSIF-2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v2 2/8] sound: soc: sh: Add RZ/G2L SSIF-2 driver
> 
> Hi Biju,
> 
> On Mon, Jul 19, 2021 at 3:40 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Add serial sound interface(SSIF-2) driver support for RZ/G2L SoC.
> >
> > Based on the work done by Chris Brandt for RZ/A SSI driver.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/sound/soc/sh/Kconfig
> > +++ b/sound/soc/sh/Kconfig
> > @@ -45,6 +45,16 @@ config SND_SOC_RCAR
> >         help
> >           This option enables R-Car SRU/SCU/SSIU/SSI sound support
> >
> > +config SND_SOC_RZ
> > +       tristate "RZ/G2L series SSIF-2 support"
> > +       depends on OF || COMPILE_TEST
> 
> ARCH_R9A07G044 implies OF
> 
> > +       depends on ARCH_R9A07G044
> 
> Is there any hard compile-time dependency on ARCH_R9A07G044?
> 
> Perhaps you meant
> 
>     depends on ARCH_R9A07G044 || COMPILE_TEST

OK, Will update this in the next version.

Regards,
Biju

> 
> ?
> 
> > +       select SND_SIMPLE_CARD
> > +       help
> > +         This option enables ASoC sound support for the RZ/G2L MPUs.
> > +         The simple-audio-card driver and the RZ/G2L built-in serial
> > +         sound interface (SSIF-2) driver are used.
> > +
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux