Hi Rob,
On Fri, Jul 16, 2021 at 8:02 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Wed, Jul 14, 2021 at 01:30:13PM +0200, Geert Uytterhoeven wrote:
> > - Add missing "#{address,size}-cells",
> > - Fix rejection of legitimate flash subnodes containing multiple
> > compatible values,
> > - Add missing list of required properties.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > .../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++---
> > 1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > index 990489fdd2ac33fe..c0d899a2305361b1 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > @@ -56,17 +56,34 @@ properties:
> > resets:
> > maxItems: 1
> >
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
>
> spi-controller.yaml already defines this.
spi-controller.yaml says '#address-cells' must be 0 or 1. As RPC-IF does
SPI master only, it should be 1.
Don't remember why I added the '#size-cells' too. Perhaps for symmetry?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
