On Wed, Jul 14, 2021 at 02:50:11PM +0200, Geert Uytterhoeven wrote: > Make the forward declarations of elfcorehdr_addr and elfcorehdr_size > always available, like is done for phys_initrd_start and > phys_initrd_size. Code referring to these symbols can then just check > for IS_ENABLED(CONFIG_CRASH_DUMP), instead of requiring conditional > compilation using an #ifdef, thus preparing to increase compile > coverage. > > Suggested-by: Rob Herring <robh+dt@xxxxxxxxxx> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > v4: > - New. > --- > include/linux/crash_dump.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index a5192b718dbe4f9a..ad31893d13d634de 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -10,13 +10,14 @@ > > #include <linux/pgtable.h> /* for pgprot_t */ > > +/* For IS_ENABLED(CONFIG_CRASH_DUMP) */ > +extern unsigned long long elfcorehdr_addr; > +extern unsigned long long elfcorehdr_size; > + > #ifdef CONFIG_CRASH_DUMP > #define ELFCORE_ADDR_MAX (-1ULL) > #define ELFCORE_ADDR_ERR (-2ULL) Seems like these could be needed and no need to hide them, so perhaps just move the #ifdef down. > > -extern unsigned long long elfcorehdr_addr; > -extern unsigned long long elfcorehdr_size; > - > extern int elfcorehdr_alloc(unsigned long long *addr, unsigned long long *size); > extern void elfcorehdr_free(unsigned long long addr); > extern ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos); > -- > 2.25.1 > >
