Hi Geert,
Thank you for the patch.
On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote:
> As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> CONFIG_FB"), CONFIG_FB is no longer auto-enabled. While CONFIG_FB may
> be considered unneeded for systems where graphics is provided by a DRM
> driver, R-Mobile A1 still relies on a frame buffer device driver for
> graphics support.
>
> Restore support for graphics on R-Mobile A1 and graphical consoles on
> DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for
> Renesas ARM systems.
Does anyone still care about the Armadillo board ?
This being said, I think CONFIG_FB should be added , but for a different
reason. There's no KMS console driver, so the only option we have today,
even when a KMS driver is available, is to go through FBDEV emulation,
which requires CONFIG_FB to be enabled.
> Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> To be queued as a fix for v5.14.
> ---
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 66c8b0980a0a744d..d9a27e4e09140b43 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -135,6 +135,7 @@ CONFIG_DRM_SII902X=y
> CONFIG_DRM_SIMPLE_BRIDGE=y
> CONFIG_DRM_I2C_ADV7511=y
> CONFIG_DRM_I2C_ADV7511_AUDIO=y
> +CONFIG_FB=y
> CONFIG_FB_SH_MOBILE_LCDC=y
> CONFIG_BACKLIGHT_PWM=y
> CONFIG_BACKLIGHT_AS3711=y
--
Regards,
Laurent Pinchart
