Hi Geert,
Thanks for your feedback.
On 2021-07-07 16:42:10 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> Thanks for your patch!
>
> On Wed, Jul 7, 2021 at 3:14 PM Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > The loop counter 'i' should be unsigned int to match struct
> > rcar_gen3_thermal_priv num_tscs where it's stored.
>
> It is also stored in rcar_gen3_thermal_tsc.id, which is still (signed) int.
Thanks.
>
> > --- a/drivers/thermal/rcar_gen3_thermal.c
> > +++ b/drivers/thermal/rcar_gen3_thermal.c
> > @@ -423,7 +423,8 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> > struct device *dev = &pdev->dev;
> > struct resource *res;
> > struct thermal_zone_device *zone;
> > - int ret, i;
> > + unsigned int i;
> > + int ret;
> >
> > /* default values if FUSEs are missing */
> > /* TODO: Read values from hardware on supported platforms */
>
> And perhaps:
>
> - dev_info(dev, "TSC%d: Loaded %d trip points\n", i, ret);
> + dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
>
> ?
Good catch, why do my compiler not warn for this? Did you catch this by
review or have you some compiler magic I'm missing?
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
