> > I don't fully understand how the refactoring should look like? Is it
> > moving 'struct renesas_sdhi_quirks' to renesas_sdhi_internal_dmac.c and
> > merge it there with renesas_sdhi_of_data? Is it really better to copy
> > this struct per SoC? Most of the data is the same.
>
> I also have the same concern. But, I guess we can refactor
> the renesas_sdhi_of_data like below to avoid increasing data size:
>
> struct renesas_sdhi_of_data_with_quirks {
> const struct renesas_sdhi_of_data *of_data;
> const struct renesas_sdhi_quirks *quirks;
> };
>
> And then, we can keep of_rcar_gen3_compatible and
> we can add each SoC's renesas_sdhi_of_data_with_quirks
> and set it to the .data.
That sounds like a reasonable approach to me. This would also allow us
to merge the quirks from sdhi_core with the quirks from
sdhi_internal_dmac.
Attachment:
signature.asc
Description: PGP signature
