Hi Kieran, On Wed, Jun 23, 2021 at 1:43 AM Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> wrote: > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > Provide the device nodes for the DU on the V3U platforms. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -1142,6 +1142,37 @@ vspd1: vsp@fea28000 { > renesas,fcp = <&fcpvd1>; > }; > > + du: display@feb00000 { > + compatible = "renesas,du-r8a779a0"; > + reg = <0 0xfeb00000 0 0x40000>; > + interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 411>, > + <&cpg CPG_MOD 411>; > + clock-names = "du.0", "du.1"; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 411>; > + vsps = <&vspd0 0>, <&vspd1 0>; > + status = "disabled"; Modulo my comments on the clock part of the bindings: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds