Hi Laurent, These all look fine to me independently, so for the set: Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> and of course as I've been using them Tested-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx As you've seen, I've posted an update to simplify the DSI startup so that it doesn't need to be called directly from the crtc, which also removes the header addition change I had in this series ;-) Squashing these down, I still see a few checkpatch issues, but I think they can be tackled as part of squashing so they don't need discussing here. -- Kieran On 23/06/2021 04:46, Laurent Pinchart wrote: > Hello, > > This patch series adds a driver for the DSI encoder found in the R-Car > V3U SoC, which is the first SoC in the family that supports DSI. > > The driver is based on an implementation from the BSP written by Luu > Hoai, taken as-is in patch 02/15. The subsequent patches are cleanups. > I'm posting this version as an RFC to allow Luu to review the cleanups, > if desired. I've thus restricted the audience to the linux-renesas-soc > mailing list. The next, non-RFC version will squash all driver patches > into one and will be posted to dri-devel. > > There's one open question related to whether the DSI encoder clock needs > to be controlled explicitly by the DU or not. Depending on the outcome > of the tests, the driver could be further simplified. > > Kieran Bingham (2): > drm: rcar-du: dsi: Use the correct compatible > drm: rcar-du: dsi: Include the DSI header > > LUU HOAI (1): > drm: rcar-du: Add R-Car DSI driver > > Laurent Pinchart (12): > dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX > drm: rcar-du: dsi: Reorganize probe function > drm: rcar-du: dsi: Use dev_err_probe() > drm: rcar-du: dsi: Shorten mipi_dsi variable name to dsi > drm: rcar-du: dsi: Use dsi->dev consistently in probe() > drm: rcar-du: dsi: Get next bridge in probe() > drm: rcar-du: dsi: Simplify DT parsing > drm: rcar-du: dsi: Add error handling in rcar_mipi_dsi_clk_enable() > drm: rcar-du: dsi: Simplify error handling in rcar_mipi_dsi_enable() > drm: rcar-du: dsi: Turn container_of() wrappers to inline functions > drm: rcar-du: dsi: Various style and typo fixes > drm: rcar-du: dsi: Use read_poll_timeout() > > .../display/bridge/renesas,dsi-csi2-tx.yaml | 118 +++ > drivers/gpu/drm/rcar-du/Kconfig | 6 + > drivers/gpu/drm/rcar-du/Makefile | 1 + > drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 813 ++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_mipi_dsi.h | 26 + > drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h | 172 ++++ > 6 files changed, 1136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > create mode 100644 drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > create mode 100644 drivers/gpu/drm/rcar-du/rcar_mipi_dsi.h > create mode 100644 drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h >
