Hi Biju, On Fri, Jun 11, 2021 at 1:36 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > Document RZ/G2L DMAC bindings. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/renesas,rz-dmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/G2L DMA Controller > + > +maintainers: > + - Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,dmac-r9a07g044 # RZ/G2{L,LC} Please use "renesas,r9a07g044-dmac". > + - const: renesas,rz-dmac Does this need many changes for RZ/A1H and RZ/A2M? > + renesas,rz-dmac-slavecfg: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + DMA configuration for a slave channel. Each channel must have an array of > + 3 items as below. > + first item in the array is MID+RID Already in dmas. > + second item in the array is slave src or dst address As pointed out by Rob, already known by the slave driver. > + third item in the array is channel configuration value. What exactly is this? Does the R-Car DMAC have this too? If yes, how does its driver handle it? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
