Hi Geert,
Thank you for the review.
On Thu, Jun 10, 2021 at 1:22 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Wed, Jun 9, 2021 at 6:37 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Add DT binding documentation for SYSC controller found on
> > RZ/G2{L,LC,UL} SoC's.
> >
> > SYSC block contains the LSI_DEVID register which is used to retrieve
> > SoC product information.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for the update!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml
> > @@ -0,0 +1,63 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/power/renesas,rzg2l-sysc.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: Renesas RZ/G2L System Controller (SYSC)
> > +
> > +maintainers:
> > + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > +
> > +description:
> > + The RZ/G2L System Controller (SYSC) performs system control of the LSI and
> > + supports following functions,
> > + - External terminal state capture function
> > + - 34-bit address space access function
> > + - Low power consumption control
> > + - WDT stop control
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,r9a07g044-sysc # RZ/G2{L,LC}
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + items:
> > + - description: CA55/CM33 Sleep/Software Standby Mode request interrupt
> > + - description: CA55 Software Standby Mode release request interrupt
> > + - description: CM33 Software Standby Mode release request interrupt
> > + - description: CA55 ACE Asynchronous Bridge Master/Slave interface deny request interrupt
> > +
> > + interrupt-names:
> > + items:
> > + - const: sys_lpm_int
> > + - const: sys_ca55stbydone_int
> > + - const: sys_cm33stbyr_int
> > + - const: sys_ca55_deny
>
> The "sys_" prefixes feel superfluous to me.
> If you don't mind, I can remove them while applying (also from example
> and .dtsi).
>
Fine with me, thank you for taking care of that.
Cheers,
Prabhakar
