Hi Geert, Thanks for your work. On 2021-06-07 19:39:01 +0200, Geert Uytterhoeven wrote: > Hi all, > > The Renesas Salvator-X(S) family of boards are available with different > SiP options (R-Car H3 ES1.x, H3 ES2.0+, M3-W, M3-W+, M3-N). To reduce > duplication of board descriptions, the parts common to all SoC and board > combinations are already factored out into salvator-common.dtsi, > salvator-x.dtsi, and salvator-xs.dtsi. Still, there are a few board > features that are not common to all combos, as the corresponding support > is not present on all SoCs. > > Hence this patch series moves out support for the second HDMI channel, > the SATA interface, and the third and fourth USB channels to > salvator-common.dtsi and/or salvator-xs.dtsi. As these are not present > on all SoCs, its descriptions are protected by SOC_HAS_* preprocessor > symbols, defined in SoC-specific .dtsi files. > > This series causes no changes in the generated DTB, except for the > enablement of the SATA device node on Salvator-X board with an R-Car > M3-N SiP, cfr. the comments in [PATCH 2/4]. > > Thanks for your comments! With a bit more of logic in dts files we might get back to board files ;-) For the whole series, Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Geert Uytterhoeven (4): > arm64: dts: renesas: salvator-x(s): Factor out HDMI1 parts > arm64: dts: renesas: salvator-x(s): Factor out SATA parts > arm64: dts: renesas: salvator-x(s): Factor out USB ch2 parts > arm64: dts: renesas: salvator-xs: Factor out USB ch3 parts > > .../boot/dts/renesas/r8a77950-salvator-x.dts | 73 ----------- > arch/arm64/boot/dts/renesas/r8a77950.dtsi | 2 + > .../boot/dts/renesas/r8a77951-salvator-x.dts | 73 ----------- > .../boot/dts/renesas/r8a77951-salvator-xs.dts | 122 ------------------ > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 5 + > .../boot/dts/renesas/r8a77965-salvator-xs.dts | 14 -- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 + > .../boot/dts/renesas/salvator-common.dtsi | 76 ++++++++++- > arch/arm64/boot/dts/renesas/salvator-xs.dtsi | 56 ++++++++ > 9 files changed, 140 insertions(+), 283 deletions(-) > > -- > 2.25.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Niklas Söderlund