On 08.05.2021 23:47, Sergei Shtylyov wrote:
Posting a review of the already commited (over my head) patch. It would have
been appropriate if the patch looked OK but it's not. :-/
When a lot of frames were received in the short term, the driver
caused a stuck of receiving until a new frame was received. For example,
the following command from other device could cause this issue.
$ sudo ping -f -l 1000 -c 1000 <this driver's ipaddress>
-l is essential here, right?
Have you tried testing sh_eth sriver like that, BTW?
It's driver! :-)
The previous code always cleared the interrupt flag of RX but checks
the interrupt flags in ravb_poll(). So, ravb_poll() could not call
ravb_rx() in the next time until a new RX frame was received if
ravb_rx() returned true. To fix the issue, always calls ravb_rx()
regardless the interrupt flags condition.
That bacially defeats the purpose of IIUC...
^ NAPI,
I was sure I typed NAPI here, yet it got lost in the edits. :-)
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
[...]
MBR, Sergei
