Hi Geert,
Thank you for the patch.
On Thu, Apr 29, 2021 at 02:41:15PM +0200, Geert Uytterhoeven wrote:
> "make dtbs_check" complains:
>
> arch/arm/boot/dts/r8a7779-marzen.dt.yaml: display@fff80000: clock-names:0: 'du.0' was expected
>
> Change the first clock name to match the DT bindings.
> This has no effect on actual operation, as the Display Unit driver in
> Linux does not use the first clock name on R-Car H1, but just grabs the
> first clock.
The driver agrees with that statement. I haven't tested it though.
> Fixes: 665d79aa47cb3983 ("ARM: shmobile: marzen: Add DU external pixel clock to DT")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> To be queued in renesas-devel for v5.14.
>
> arch/arm/boot/dts/r8a7779-marzen.dts | 2 +-
> arch/arm/boot/dts/r8a7779.dtsi | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts b/arch/arm/boot/dts/r8a7779-marzen.dts
> index d2240b89ee52929b..46584532349590d1 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> @@ -145,7 +145,7 @@ &du {
> status = "okay";
>
> clocks = <&mstp1_clks R8A7779_CLK_DU>, <&x3_clk>;
> - clock-names = "du", "dclkin.0";
> + clock-names = "du.0", "dclkin.0";
>
> ports {
> port@0 {
> diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
> index 74d7e9084eabe173..3c5fcdfe16b87182 100644
> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi
> @@ -463,6 +463,7 @@ du: display@fff80000 {
> reg = <0xfff80000 0x40000>;
> interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&mstp1_clks R8A7779_CLK_DU>;
> + clock-names = "du.0";
> power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;
> status = "disabled";
>
--
Regards,
Laurent Pinchart
