Re: [PATCH renesas-drivers] dt-bindings: misc: Fix logic analyzer bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for your work.

On 2021-04-29 11:30:37 +0200, Geert Uytterhoeven wrote:
> When running "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties:required: ['compatible', 'probe-gpios'] is not of type 'object', 'boolean'
>     Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'required'
>       SCHEMA  Documentation/devicetree/bindings/processed-schema-examples.json
>     Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml: ignoring, error in schema: properties: required
>     warning: no schema found in file: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> 
> and:
> 
>     Error: Documentation/devicetree/bindings/misc/gpio-logic-analyzer.example.dts:22.42-43 syntax error
>     FATAL ERROR: Unable to parse input tree
> 
> Fix this by correcting the indentation of the "required" block, and
> adding the missing include.
> 
> Fixes: 1c8e77fc12417023 ("misc: add simple logic analyzer using polling")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  .../devicetree/bindings/misc/gpio-logic-analyzer.yaml      | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> index e664cec85a72facd..5516f95b72d53ff1 100644
> --- a/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> +++ b/Documentation/devicetree/bindings/misc/gpio-logic-analyzer.yaml
> @@ -22,14 +22,15 @@ properties:
>      description:
>        names used to distinguish the probes
>  
> -  required:
> -    - compatible
> -    - probe-gpios
> +required:
> +  - compatible
> +  - probe-gpios
>  
>  additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/gpio/gpio.h>
>      i2c-analyzer {
>              compatible = "gpio-logic-analyzer";
>  
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux