Hi Niklas,
Thank you for the patch.
On Wed, Apr 21, 2021 at 05:02:21PM +0200, Niklas Söderlund wrote:
> The port@0 is a mandatory port, add or move the declaration to the CSI-2
> nodes top declared in dtsi files instead of depending on dts files
> adding them when describing the external connection.
>
> This fixes validation warnings for DTB outputs that does not connect all
> CSI-2 receivers to transmitters and thus declaring all port@0 nodes in
> dts files.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> ...hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ++++
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a77950.dtsi | 4 ++++
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 12 ++++++++++++
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a77961.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 4 ++++
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 8 ++++++++
> arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ++++
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 3 ---
> 15 files changed, 84 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi
> index c62ddb9b2ba565e9..3771144a2ce49a45 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-aistarvision-mipi-adapter-2.1.dtsi
> @@ -14,7 +14,6 @@ &csi20 {
>
> ports {
> port@0 {
> - reg = <0>;
> csi20_in: endpoint {
> clock-lanes = <0>;
> data-lanes = <1 2>;
> @@ -29,7 +28,6 @@ &csi40 {
>
> ports {
> port@0 {
> - reg = <0>;
> csi40_in: endpoint {
> clock-lanes = <0>;
> data-lanes = <1 2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index d64fb8b1b86c3731..46f8dbf6890482d9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2573,6 +2573,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
I wonder if we should also add #address-cells and #size-cells. That
could simplify the board DT files, but on the other hand, as this is a
CSI-2 input, having multiple endpoints would probably be very rare. It's
probably good enough to leave it as-is.
Trusting that you've addressed all occurrences,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2628,6 +2632,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 5b05474dc2727884..d16a4be5ef77a21b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -2419,6 +2419,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2474,6 +2478,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index 20fa3caa050e5d5e..1aef34447abd1b3d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -1823,6 +1823,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 8eb006cbd9af4c98..1f51237ab0a648fa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -2709,6 +2709,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2764,6 +2768,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77950.dtsi b/arch/arm64/boot/dts/renesas/r8a77950.dtsi
> index 25b87da32eebb6dc..b643d3079db1e7aa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77950.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77950.dtsi
> @@ -192,6 +192,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 5c39152e45707441..85d66d15465ab2b6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3097,6 +3097,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3152,6 +3156,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -3191,6 +3199,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index 25d947a81b294a81..12476e354d746d0e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2761,6 +2761,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2816,6 +2820,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index ab081f14af9aa0fb..d9804768425a7603 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2499,6 +2499,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2554,6 +2558,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 657b20d3533bd398..dcb9df861d749692 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2575,6 +2575,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -2630,6 +2634,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 5a5d5649332a8b1d..e8f6352c3665f44c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1106,6 +1106,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 1ffa4a995a7ab8ae..7b51d464de0eac8b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1439,6 +1439,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1478,6 +1482,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 295d34f1d216d963..4715e4a4abe064cd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -298,8 +298,6 @@ &csi40 {
>
> ports {
> port@0 {
> - reg = <0>;
> -
> csi40_in: endpoint {
> clock-lanes = <0>;
> data-lanes = <1 2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 5010f23fafcc7f98..0eaea58f4210d89a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -1970,6 +1970,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index e18747df219f8118..453ffcef24fae1be 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -349,7 +349,6 @@ &csi20 {
>
> ports {
> port@0 {
> - reg = <0>;
> csi20_in: endpoint {
> clock-lanes = <0>;
> data-lanes = <1>;
> @@ -364,8 +363,6 @@ &csi40 {
>
> ports {
> port@0 {
> - reg = <0>;
> -
> csi40_in: endpoint {
> clock-lanes = <0>;
> data-lanes = <1 2 3 4>;
--
Regards,
Laurent Pinchart
