> Hi Dinghao, > > On Thu, Apr 15, 2021 at 9:33 AM Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote: > > The error handling paths after pm_runtime_get_sync() has no > > refcount decrement, which leads to refcount leak. > > > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > > --- > > > > Changelog: > > > > v2: - Move the position of pm_runtime_enable,_get_sync(). > > Use devm_clk_register() to simplify error handling. > > Thanks for the update! > > > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c > > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c > > @@ -131,7 +131,6 @@ static int rcar_usb2_clock_sel_remove(struct platform_device *pdev) > > struct usb2_clock_sel_priv *priv = platform_get_drvdata(pdev); > > warning: unused variable ‘priv’ [-Wunused-variable] > > Have you compiled this? > This is my carelessness, thanks for pointing out this. When we use devm_clk_hw_register(), we will not need to unregister priv->hw in rcar_usb2_clock_sel_remove(). So I think it's okay to remove platform_get_drvdata() in it to eliminate this warning. Do you need a new version of patch to fix this warning? Regards, Dinghao
