> -----Original Message----- > From: Dominique MARTINET <dominique.martinet@xxxxxxxxxxxxxxxxx> > Sent: 2021年4月19日 12:49 > To: Alice Guo (OSS) <alice.guo@xxxxxxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; rafael@xxxxxxxxxx; Horia Geanta > <horia.geanta@xxxxxxx>; Aymen Sghaier <aymen.sghaier@xxxxxxx>; > herbert@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; tony@xxxxxxxxxxx; > geert+renesas@xxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; > vkoul@xxxxxxxxxx; peter.ujfalusi@xxxxxxxxx; a.hajda@xxxxxxxxxxx; > narmstrong@xxxxxxxxxxxx; robert.foss@xxxxxxxxxx; airlied@xxxxxxxx; > daniel@xxxxxxxx; khilman@xxxxxxxxxxxx; tomba@xxxxxxxxxx; jyri.sarha@xxxxxx; > joro@xxxxxxxxxx; will@xxxxxxxxxx; mchehab@xxxxxxxxxx; > ulf.hansson@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; kishon@xxxxxx; > kuba@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; Roy Pledge <roy.pledge@xxxxxxx>; > Leo Li <leoyang.li@xxxxxxx>; ssantosh@xxxxxxxxxx; matthias.bgg@xxxxxxxxx; > edubezval@xxxxxxxxx; j-keerthy@xxxxxx; balbi@xxxxxxxxxx; > linux@xxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; wim@xxxxxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > linux-omap@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; > linux-clk@xxxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; > dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-amlogic@xxxxxxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; > linux-media@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx; > linux-gpio@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; > linux-staging@xxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; > linux-pm@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > linux-watchdog@xxxxxxxxxxxxxxx > Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match > returning -EPROBE_DEFER > > First comment overall for the whole serie: > Since it is the solution I had suggested when I reported the problem[1] I have no > qualm on the approach, comments for individual patches follow. > > [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@xxxxxxxxxxxxxxxxx > > > Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > > From: Alice Guo <alice.guo@xxxxxxx> > > > > In i.MX8M boards, the registration of SoC device is later than caam > > driver which needs it. Caam driver needs soc_device_match to provide > > -EPROBE_DEFER when no SoC device is registered and no > > early_soc_dev_attr. > > This patch should be last in the set: you can't have soc_device_match return an > error before its callers handle it. > > > Signed-off-by: Alice Guo <alice.guo@xxxxxxx> > > As the one who reported the problem I would have been appreciated being at > least added to Ccs... I only happened to notice you posted this by chance. Sorry. I will Cc you next time. > There is also not a single Fixes tag -- I believe this commit should have Fixes: > 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure > how such tags should be handled in case of multiple patches fixing something. I only mentioned "soc: imx8m: change to use platform driver" in cover letter. If it is acceptable to make such a modification, I will send non-RFC and add Fixes tag. Best Regards, Alice > -- > Dominique
