On Thu, Apr 8, 2021 at 11:21 AM Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > > Hello Andy, > > On Wed, 2021-04-07 at 16:21 +0300, Andy Shevchenko wrote: > > On Wed, Apr 7, 2021 at 1:04 PM Matti Vaittinen > > <matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote: > > > Provide helper function for IC's implementing regulator > > > notifications > > > when an IRQ fires. The helper also works for IRQs which can not be > > > acked. > > > Helper can be set to disable the IRQ at handler and then re- > > > enabling it > > > on delayed work later. The helper also adds > > > regulator_get_error_flags() > > > errors in cache for the duration of IRQ disabling. > > > > Thanks for an update, my comments below. After addressing them, feel > > free to add > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > I (eventually) disagreed with couple of points here and haven't changed > those. Please see list below. > > I still do think you did a really good job reviewing this - and you > should get the recognition from that work. Thus I'd nevertheless would > like to add your Reviewed-by to the next version. Please let me know if > you think it's ok. (I have the v7 ready but I'll wait until the next > Monday before sending it to see if this brings more discussion). Looks OK to me. Just rename die_loudly() to rdev_die_loudly() and in any way of conditionals with that, please mark it with __noreturn attribute, so if (bla bla bla) rdev_die_loudly(); will be an understandable trap. -- With Best Regards, Andy Shevchenko
