On Sun, Apr 4, 2021 at 7:53 PM Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx> wrote: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which > takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding > an original error code. Stop calling devm_request_irq() with the > invalid IRQ #s. > > Fixes: 6ccbe607132b ("i2c: add Renesas R-Car I2C driver") > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds