Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on next-20210401] [cannot apply to sunxi/sunxi/for-next xlnx/master wireless-drivers-next/master wireless-drivers/master robh/for-next linus/master v5.12-rc6 v5.12-rc5 v5.12-rc4 v5.12-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-004940 base: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d config: x86_64-kexec (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/98b333048aecad0da786f9f8c3fe60674442b8cf git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-004940 git checkout 98b333048aecad0da786f9f8c3fe60674442b8cf # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:630:1: error: conflicting types for 'stmmac_probe_config_dt' 630 | stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:20: drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h:15:1: note: previous declaration of 'stmmac_probe_config_dt' was here 15 | stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/linkage.h:7, from include/linux/kernel.h:8, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:6, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:11: drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:640:19: error: conflicting types for 'stmmac_probe_config_dt' 640 | EXPORT_SYMBOL_GPL(stmmac_probe_config_dt); | ^~~~~~~~~~~~~~~~~~~~~~ include/linux/export.h:98:21: note: in definition of macro '___EXPORT_SYMBOL' 98 | extern typeof(sym) sym; \ | ^~~ include/linux/export.h:155:34: note: in expansion of macro '__EXPORT_SYMBOL' 155 | #define _EXPORT_SYMBOL(sym, sec) __EXPORT_SYMBOL(sym, sec, "") | ^~~~~~~~~~~~~~~ include/linux/export.h:159:33: note: in expansion of macro '_EXPORT_SYMBOL' 159 | #define EXPORT_SYMBOL_GPL(sym) _EXPORT_SYMBOL(sym, "_gpl") | ^~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:640:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL' 640 | EXPORT_SYMBOL_GPL(stmmac_probe_config_dt); | ^~~~~~~~~~~~~~~~~ In file included from drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:20: drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h:15:1: note: previous declaration of 'stmmac_probe_config_dt' was here 15 | stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac); | ^~~~~~~~~~~~~~~~~~~~~~ vim +/stmmac_probe_config_dt +630 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c d2ed0a7755fe14 Johan Hovold 2016-11-30 614 d2ed0a7755fe14 Johan Hovold 2016-11-30 615 /** d2ed0a7755fe14 Johan Hovold 2016-11-30 616 * stmmac_remove_config_dt - undo the effects of stmmac_probe_config_dt() d2ed0a7755fe14 Johan Hovold 2016-11-30 617 * @pdev: platform_device structure d2ed0a7755fe14 Johan Hovold 2016-11-30 618 * @plat: driver data platform structure d2ed0a7755fe14 Johan Hovold 2016-11-30 619 * d2ed0a7755fe14 Johan Hovold 2016-11-30 620 * Release resources claimed by stmmac_probe_config_dt(). d2ed0a7755fe14 Johan Hovold 2016-11-30 621 */ d2ed0a7755fe14 Johan Hovold 2016-11-30 622 void stmmac_remove_config_dt(struct platform_device *pdev, d2ed0a7755fe14 Johan Hovold 2016-11-30 623 struct plat_stmmacenet_data *plat) d2ed0a7755fe14 Johan Hovold 2016-11-30 624 { 4838a54050284d Jose Abreu 2019-06-14 625 of_node_put(plat->phy_node); a249708bc2aa1f Julia Lawall 2017-01-17 626 of_node_put(plat->mdio_node); d2ed0a7755fe14 Johan Hovold 2016-11-30 627 } 6a228452d11eaf Stefan Roese 2012-03-13 628 #else 402dae0bed98dd Joachim Eastwood 2015-07-17 629 struct plat_stmmacenet_data * b0003ead75f394 Joachim Eastwood 2015-07-17 @630 stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) 6a228452d11eaf Stefan Roese 2012-03-13 631 { b2a8315a5c655f LABBE Corentin 2017-02-08 632 return ERR_PTR(-EINVAL); 6a228452d11eaf Stefan Roese 2012-03-13 633 } d2ed0a7755fe14 Johan Hovold 2016-11-30 634 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
