Re: [PATCH 1/2] sh73a0 CMT1 device exposed via UIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Magnus,

On Sun, Mar 21, 2021 at 1:12 PM Magnus Damm <damm@xxxxxxxxxxxxx> wrote:
> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>
> Modify the kernel slightly to expose CMT1 via UIO and print some
> IRQ-related messages from UIO for debugging purpose.
>
> Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>

Thanks for your patch!

> --- 0001/arch/arm/boot/dts/sh73a0.dtsi
> +++ work/arch/arm/boot/dts/sh73a0.dtsi  2021-03-21 18:15:44.683760186 +0900
> @@ -99,7 +99,7 @@
>         };
>
>         cmt1: timer@e6138000 {
> -               compatible = "renesas,sh73a0-cmt1";
> +               compatible = "uio_pdrv_genirq";

DT describes hardware, not software policy, so please drop this part.

> --- 0001/drivers/uio/uio_pdrv_genirq.c
> +++ work/drivers/uio/uio_pdrv_genirq.c  2021-03-21 18:15:03.120757568 +0900
> @@ -276,7 +282,7 @@ static const struct dev_pm_ops uio_pdrv_
>
>  #ifdef CONFIG_OF
>  static struct of_device_id uio_of_genirq_match[] = {
> -       { /* This is filled with module_parm */ },
> +       { .compatible = "uio_pdrv_genirq", },

The comment you removed tells you how to use this driver ;-)
Alternative, please use driver_override and bind in sysfs.

>         { /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, uio_of_genirq_match);

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux