On Tue, Mar 16, 2021 at 8:05 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
Care to also fix 'idt,xtal-load-femtofarads' which was recently added?
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> ---
> This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage", which
> is part of dt-schema v2021.2.1.
>
> v4:
> - Add Reviewed-by, Acked-by,
>
> v3:
> - Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
>
> v2:
> - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> ('clk: vc5: Use "idt,voltage-microvolt" instead of
> "idt,voltage-microvolts"'),
> - Drop reference to clock.yaml, which is already applied
> unconditionally,
> - Drop removal of allOf around if condition, as it is unnecessary
> churn.
> ---
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index c268debe5b8d58cd..a7d00c552e3de161 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -84,9 +84,10 @@ patternProperties:
> enum: [ 1800000, 2500000, 3300000 ]
> idt,slew-percent:
> description: The Slew rate control for CMOS single-ended.
> - $ref: /schemas/types.yaml#/definitions/uint32
> enum: [ 80, 85, 90, 100 ]
>
> + additionalProperties: false
> +
> required:
> - compatible
> - reg
> @@ -141,13 +142,13 @@ examples:
> clock-names = "xin";
>
> OUT1 {
> - idt,drive-mode = <VC5_CMOSD>;
> - idt,voltage-microvolts = <1800000>;
> + idt,mode = <VC5_CMOSD>;
> + idt,voltage-microvolt = <1800000>;
> idt,slew-percent = <80>;
> };
>
> OUT4 {
> - idt,drive-mode = <VC5_LVDS>;
> + idt,mode = <VC5_LVDS>;
> };
> };
> };
> --
> 2.25.1
>
