Hi Niklas,
On Tue, Mar 9, 2021 at 5:28 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Add support for thermal.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> * Changes since v1
> - Add fifth TSC node.
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -260,6 +260,19 @@ sysc: system-controller@e6180000 {
> #power-domain-cells = <1>;
> };
>
> + tsc: thermal@e6190000 {
> + compatible = "renesas,r8a779a0-thermal";
> + reg = <0 0xe6190000 0 0x100>,
> + <0 0xe6198000 0 0x100>,
> + <0 0xe61a0000 0 0x100>,
> + <0 0xe61a8000 0 0x100>,
> + <0 0xe61b0000 0 0x100>;
0x100 doesn't cover all registers. What about 0x200?
> + clocks = <&cpg CPG_MOD 919>;
> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> + resets = <&cpg 919>;
> + #thermal-sensor-cells = <1>;
> + };
The rest looks good to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
