Hi Geert,
Thanks for you feedback!
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 26 February 2021 09:37
> Subject: Re: [PATCH 6/7] arm64: dts: renesas: r8a77965: Add DAB support
>
> Hi Fabrizio,
>
> On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro
> <fabrizio.castro.jz@xxxxxxxxxxx> wrote:
> > R-Car M3-N (a.k.a. r8a77965) comes with the DAB hardware accelerator.
> > This patch adds SoC specific support.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
>
> LGTM (ignoring clock-names bikeshedding)
Will change the clock name as per your suggestion.
Thanks,
Fab
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > @@ -1013,6 +1013,18 @@ ipmmu_vp0: iommu@fe990000 {
> > #iommu-cells = <1>;
> > };
> >
> > + dab: dab@e6730000 {
> > + compatible = "renesas,dab-r8a77965",
> > + "renesas,rcar-gen3-dab";
> > + reg = <0x00 0xe6730000 0x00 0x120>;
> > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 1016>;
> > + clock-names = "dab";
> > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> > + resets = <&cpg 1016>;
> > + status = "disabled";
> > + };
> > +
> > avb: ethernet@e6800000 {
> > compatible = "renesas,etheravb-r8a77965",
> > "renesas,etheravb-rcar-gen3";
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
