Hi Shimoda-san,
On Mon, Mar 1, 2021 at 4:13 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > From: Yoshihiro Shimoda, Sent: Friday, February 26, 2021 10:02 AM
> > > From: Geert Uytterhoeven, Sent: Thursday, February 25, 2021 9:47 PM
> > > On Thu, Feb 25, 2021 at 1:16 PM Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > > @@ -36,6 +36,9 @@
> > > > serial0 = &scif2;
> > > > serial1 = &hscif1;
> > > > ethernet0 = &avb;
> > > > + mmc0 = &sdhi0;
> > > > + mmc1 = &sdhi2;
> > > > + mmc2 = &sdhi3;
> > > > };
> > >
> > > Looks like on Salvator-X(S) the two SD card slots are labeled
> > > SD0 and SD3, so the last one should be mmc3?
> > >
> > > What's most important? Getting the naming right, or matching the
> > > traditional naming?
> >
> > Most important is stable these mmcblkN naming for using it on
> > the "root=" parameter :)
> >
> > I don't have a strong opinion though, IMO, matching the traditional naming
> > is better than board labeled because:
> > - we don't need to add any alias into a board dts if the board is using one
> > sdhi/eMMC only like r8a77995-draak.dts.
> > - also, the traditional naming is familiar to us.
>
> I'm afraid about changing my mind. But, may I use eMMC channel as mmc0?
“A wise man changes his mind sometimes, but a fool never."
> This mean that I'd like to change the aliases as below.
>
> + mmc0 = &sdhi2;
> + mmc1 = &sdhi0;
> + mmc2 = &sdhi3;
>
> This is because it's easy to imagine mmcblk0 as eMMC
> and super old kernels (v5.4 or or earlier) were probed as mmcblk0
> so that we can use "root=/dev/mmcblk0pN" on the kernel parameter.
Makes sense. I had a look at my R-Car H3 ES1.0/Salvator-X boot logs,
which shows the following history:
- v4.7..v4.9-rc8: mmc0 = SD0 mmc1 = SD3
- v4.8-rc7..v5.4-rc1: mmc0 = eMMC mmc1 = SD0 mmc2 = SD3
- v5.4-rc3..v5.11-rc7: mmc0 = SD0 mmc1 = eMMC mmc2 = SD3
- v5.9-rc7..v5.11: mmc0 = SD0 mmc1 = SD3 mmc2 = eMMC
Note that (1) this includes both mainline and development kernels based
on renesas-drivers, and (2) naming could be unstable, hence the
overlapping ranges.
So I'll be waiting for your v4...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
