Hi Saravana,
On Mon, Feb 15, 2021 at 10:03 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> On Mon, Feb 15, 2021 at 11:10 AM Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
> > On Mon, Feb 15, 2021 at 7:37 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > > On Mon, Feb 15, 2021 at 7:14 AM Geert Uytterhoeven
> > > > @@ -148,7 +149,11 @@ static int board_staging_add_dev_domain(struct platform_device *pdev,
> > > > pd_args.np = np;
> > > > pd_args.args_count = 0;
> > > >
> > > > - return of_genpd_add_device(&pd_args, &pdev->dev);
> > > > + /* Cfr. device_pm_init_common() */
> > >
> > > What's Cfr?
> >
> > "compare to" (from Latin "confer").
>
> Can you please change this to "refer to" or "similar to"? Also, not
> sure if this comment is even adding anything useful even if you switch
> the words.
I changed it to "Initialization similar to device_pm_init_common()"
> Also, device_pm_init_common() is used in two places outside of
> drivers/base/ with this change. Maybe better to move it to
> linux/device.h?
arch/sh/drivers/platform_early.c has a separate definition, and this
is intentional, cfr. commit 507fd01d53333387 ("drivers: move the early
platform device support to arch/sh"):
In order not to export internal drivers/base functions to arch code for
this temporary solution - copy the two needed routines for driver
matching from drivers/base/platform.c to arch/sh/drivers/platform_early.c.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
