Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:42PM +0100, Jacopo Mondi wrote: > Provide a macro to define the reverse channel amplitude to > be used to compensate the remote serializer noise immunity. > > While at it, update a comment. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > drivers/media/i2c/max9286.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 4afb5ca06448..7913b5f2249e 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -113,6 +113,7 @@ > #define MAX9286_REV_TRF(n) ((n) << 4) > #define MAX9286_REV_AMP(n) ((((n) - 30) / 10) << 1) /* in mV */ > #define MAX9286_REV_AMP_X BIT(0) > +#define MAX9286_REV_AMP_HIGH 170 > /* Register 0x3f */ > #define MAX9286_EN_REV_CFG BIT(6) > #define MAX9286_REV_FLEN(n) ((n) - 20) > @@ -566,12 +567,12 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, > * channels: > * > * - Increase the reverse channel amplitude to compensate for the > - * remote ends high threshold, if not done already > + * remote ends high threshold I would have done this in the previous patch, but it doesn't matter much. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > * - Verify all configuration links are properly detected > * - Disable auto-ack as communication on the control channel are now > * stable. > */ > - max9286_reverse_channel_setup(priv, 170); > + max9286_reverse_channel_setup(priv, MAX9286_REV_AMP_HIGH); > max9286_check_config_link(priv, priv->source_mask); > > /* -- Regards, Laurent Pinchart
