Hi Wolfram, Thanks for your patch. On 2021-02-15 11:17:54 +0100, Wolfram Sang wrote: > RPM handling has been improved twice since this comment, and also SCC > handling has been improved a lot. Time to test if we the workaround can > be removed! > > Not-yet-Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> I boot tested this on M3W, M3N, H3-ES2, H3-ES1 and Koelsch without any noticeable issues. It feels nice that we can get rid of this. Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > > I'd be very grateful if you guys could have this patch boot-tested with > your boardfarms. If the failure is still there, then it used to hang > when detecting the eMMC. Maybe these days eMMC will just not show up. > But hopefully all is well now. This always was difficult to trigger, so > a wide test coverage would be highly appreciated. It works for me(tm), > but that is not enough here. > > drivers/mmc/host/tmio_mmc_core.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c > index 49c2d406c48e..2478a91e84b2 100644 > --- a/drivers/mmc/host/tmio_mmc_core.c > +++ b/drivers/mmc/host/tmio_mmc_core.c > @@ -1160,15 +1160,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host) > mmc->caps & MMC_CAP_NEEDS_POLL || > !mmc_card_is_removable(mmc)); > > - /* > - * On Gen2+, eMMC with NONREMOVABLE currently fails because native > - * hotplug gets disabled. It seems RuntimePM related yet we need further > - * research. Since we are planning a PM overhaul anyway, let's enforce > - * for now the device being active by enabling native hotplug always. > - */ > - if (pdata->flags & TMIO_MMC_MIN_RCAR2) > - _host->native_hotplug = true; > - > /* > * While using internal tmio hardware logic for card detection, we need > * to ensure it stays powered for it to work. > -- > 2.30.0 > -- Regards, Niklas Söderlund
