Hi Luca,
On Wed, Jan 20, 2021 at 5:08 PM Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> wrote:
> On 14/01/21 13:56, Geert Uytterhoeven wrote:
> > - Add missing reference for "idt,voltage-microvolt",
> > - Add missing "additionalProperties: false" for subnodes, to catch
> > typos in properties,
> > - Fix property names in example.
> >
> > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > v2:
> > - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> > ('clk: vc5: Use "idt,voltage-microvolt" instead of
> > "idt,voltage-microvolts"'),
> > - Drop reference to clock.yaml, which is already applied
> > unconditionally,
> > - Drop removal of allOf around if condition, as it is unnecessary
> > churn.
> > ---
> > .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > index 2ac1131fd9222a86..70239f992d714ae0 100644
> > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> > @@ -75,12 +75,15 @@ patternProperties:
> > maximum: 6
> > idt,voltage-microvolt:
> > description: The output drive voltage.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> "Vendor specific properties having a standard unit suffix don't need a
> type." -- Documentation/devicetree/bindings/example-schema.yaml
Thanks, will fix in v3!
Rob: would this apply to idt,slew-percent, too?
I.e. should -percent be added to dt-schema/schemas/property-units.yaml?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
