On Wed, Jan 6, 2021 at 9:43 PM Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx> wrote: > According to the R-Car Series, 3rd Generation User's Manual: Hardware, > Rev. 1.50, there's no APSR.DM field, instead therea are 2 independent there > RX/TX clock internal delay bits. Follow the suit: remove #define APSR_DM > and rename #define's APSR_DM_{R|T}DM to APSR_{R|T}DM. > > While at it, do several more things to the declaration of *enum* APSR_BIT: > - remove superfluous indentation; > - annotate APSR_MEMS as undocumented; > - annotate APSR as R-Car Gen3 only. > > Fixes: 61fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR") > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds