On Sat, Jan 2, 2021 at 2:13 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > > > > -----Original Message----- > > From: Adam Ford <aford173@xxxxxxxxx> > > Sent: 01 January 2021 21:34 > > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx; aford@xxxxxxxxxxxxxxxxxx; Krzysztof > > Kozlowski <krzk@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Geert > > Uytterhoeven <geert+renesas@xxxxxxxxx>; Magnus Damm > > <magnus.damm@xxxxxxxxx>; Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>; > > linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support > > for RZ/G2 Series > > > > On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > wrote: > > > > > > Hi Adam, > > > > > > Thanks for the patch. > > > > > > > -----Original Message----- > > > > From: Adam Ford <aford173@xxxxxxxxx> > > > > Sent: 01 January 2021 11:39 > > > > To: linux-renesas-soc@xxxxxxxxxxxxxxx > > > > Cc: aford@xxxxxxxxxxxxxxxxxx; Adam Ford <aford173@xxxxxxxxx>; > > > > Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Rob Herring > > > > <robh+dt@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; > > > > Magnus Damm <magnus.damm@xxxxxxxxx>; Sergei Shtylyov > > > > <sergei.shtylyov@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > > > > devicetree@xxxxxxxxxxxxxxx > > > > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add > > > > support for > > > > RZ/G2 Series > > > > > > > > The RZ/G2 Series has the RPC-IF interface. > > > > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and > > > > r8a774e1 > > > > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > > --- > > > > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4 > > ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/memory- > > > > controllers/renesas,rpc-if.yaml > > > > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-i > > > > f.yaml index 6d6ba608fd22..050c66af8c2c 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc- > > > > if.yaml > > > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,r > > > > +++ pc- > > > > if.yaml > > > > @@ -26,6 +26,10 @@ properties: > > > > compatible: > > > > items: > > > > - enum: > > > > + - renesas,r8a774a1-rpc-if # RZ/G2M > > > > + - renesas,r8a774b1-rpc-if # RZ/G2N > > > > + - renesas,r8a774c0-rpc-if # RZ/G2E > > > > + - renesas,r8a774e1-rpc-if # RZ/G2H > > > > - renesas,r8a77970-rpc-if # R-Car V3M > > > > - renesas,r8a77980-rpc-if # R-Car V3H > > > > - renesas,r8a77995-rpc-if # R-Car D3 > > > > > > May be we need to update the below description as well to cover RZ/G2 > > device?? > > > > > > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device > > > > How do you want it to read? > > Since it is generic compatible string for both R-Car gen3 and RZ/G2 device, I would update the description as > > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device > > Also may be we need to update the description of config RENESAS_RPCIF in drivers/memory/Kconfig to taken care of RZ/G2 devices in a separate patch. > Thanks for the suggestion. I'll work on V2 where I update the descriptions for both. adam > Cheers, > Biju
