Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM
> On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
<snip>
> > --- a/drivers/mfd/bd9571mwv.c
> > +++ b/drivers/mfd/bd9571mwv.c
>
> > @@ -200,12 +277,14 @@ static int bd9571mwv_probe(struct i2c_client *client,
> >
> > static const struct of_device_id bd9571mwv_of_match_table[] = {
> > { .compatible = "rohm,bd9571mwv", },
> > + { .compatible = "rohm,bd9574mwf", },
> > { /* sentinel */ }
> > };
> > MODULE_DEVICE_TABLE(of, bd9571mwv_of_match_table);
> >
> > static const struct i2c_device_id bd9571mwv_id_table[] = {
> > - { "bd9571mwv", 0 },
> > + { "bd9571mwv", ROHM_CHIP_TYPE_BD9571 },
> > + { "bd9574mwf", ROHM_CHIP_TYPE_BD9574 },
>
> Why add the chip types? These are unused, and the driver uses
> autodetection of the chip variant anyway.
I just added the chip types in the future use. As you said,
these are unused and we should not add a future use in general.
So, I'll remove this change.
Also, I think I should remove the following patch.
[PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support
Best regards,
Yoshihiro Shimoda
