Hi Rob, Laurent, On Mon, Dec 21, 2020 at 11:58:27AM -0700, Rob Herring wrote: > On Wed, Dec 16, 2020 at 07:17:05PM +0200, Laurent Pinchart wrote: > > > > @@ -221,6 +241,7 @@ required: > > > > - ports > > > > - i2c-mux > > > > - gpio-controller > > > > + - maxim,reverse-channel-microvolt > > > > One comment though: You specify a default value above, which isn't very > > useful when the property is required. Should we either drop the default > > value, or make the property optional ? > > And generally added properties can't be required unless for some reason > DT's without the property are broken. My thinking was to make it required for new DTS and specify a default for the old ones that do not have the property. I'll drop required and keep the default value in next version. Thanks j > > With required dropped, > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Rob
