Thanks for the review. > On 12/01/2020 9:54 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > The above are 2.5/3.3V pins, and they are not handled correctly by > sh_pfc_pinconf_[gs]et(), which always assumes 1.8/3.3V. > > I think the simplest solution would be to split the > SH_PFC_PIN_CFG_IO_VOLTAGE flag in two flags, and the pin_to_pocctrl() > callback in two callbacks, one for 1.8/3.3V and one for 2.5/3.3V pins, > but you may have a better idea? I added new bits to the pin config that specify the voltage. That way we can easily extend it if we ever get the eminently more useful 5V, 12V and 230V pins... CU Uli
