Re: [PATCH 1/3] arm64: dts: renesas: r8a779a0: Add FCPVD support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On 16/12/2020 17:41, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Wed, Dec 16, 2020 at 05:00:16PM +0000, Kieran Bingham wrote:
>> Provide FCPVD support for the V3U.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>> index 6cf77ce9aa93..ba6fbbd8710e 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>> @@ -117,6 +117,22 @@ gic: interrupt-controller@f1000000 {
>>  			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
>>  		};
>>  
>> +		fcpvd0: fcp@fea10000 {
>> +			compatible = "renesas,fcpv";
>> +			reg = <0 0xfea10000 0 0x200>;
>> +			clocks = <&cpg CPG_MOD 508>;
>> +			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
>> +			resets = <&cpg 508>;
>> +		};
>> +
>> +		fcpvd1: fcp@fea11000 {
>> +			compatible = "renesas,fcpv";
>> +			reg = <0 0xfea2f000 0 0x200>;
> 
> This doesn't match the node address (the former being correct I
> believe). With this fixed,

Oh dear, that's bad indeed.

I'm sorry - could you help me locate the correct buttons on my keyboard
to fix this please? :

> https://as1.ftcdn.net/jpg/00/74/64/78/500_F_74647888_XIrZ25aSYKhu5YB4PyuU7qYqzAJr3EjQ.jpg

:-D

> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks.

K

> 
>> +			clocks = <&cpg CPG_MOD 509>;
>> +			power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
>> +			resets = <&cpg 509>;
>> +		};
>> +
>>  		prr: chipid@fff00044 {
>>  			compatible = "renesas,prr";
>>  			reg = <0 0xfff00044 0 4>;
> 




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux