Hi Geert-san, Matti-san,
> From: Geert Uytterhoeven, Sent: Wednesday, December 16, 2020 1:13 AM
> On Tue, Dec 15, 2020 at 5:02 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Fri, Dec 11, 2020 at 3:03 PM Vaittinen, Matti
> > <Matti.Vaittinen@xxxxxxxxxxxxxxxxx> wrote:
> > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
<snip>
> > > > --- a/drivers/regulator/bd9571mwv-regulator.c
> > > > +++ b/drivers/regulator/bd9571mwv-regulator.c
> > > > @@ -17,7 +17,7 @@
> > > > #include <linux/mfd/bd9571mwv.h>
> > > >
> > > > struct bd9571mwv_reg {
> > > > - struct bd9571mwv *bd;
> > > > + struct regmap *regmap;
> > >
> > > As a 'nit':
> > > I might consider adding the dev pointer here to avoid extra argument
> > > with all the bkup_mode functions below. (just pass this struct and
> > > mode). But that's only my preference - feel free to ignore this comment
> > > if patch is Ok to Mark, Marek & Others :)
> >
> > Struct regmap already contains a struct device pointer, but that's internal
> > to regmap.
> >
> > Perhaps adding a regmap_device() helper to retrieve the device pointer
> > might be worthwhile?
>
> -EEXISTS ;-)
>
> struct device *regmap_get_device(struct regmap *map)
Thank you for finding this. I'll fix this patch.
Best regards,
Yoshihiro Shimoda
