Hi Niklas,
On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -128,6 +128,11 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
> DEF_MOD("fdp1-2", 117, R8A7795_CLK_S2D1), /* ES1.x */
> DEF_MOD("fdp1-1", 118, R8A7795_CLK_S0D1),
> DEF_MOD("fdp1-0", 119, R8A7795_CLK_S0D1),
> + DEF_MOD("tmu4", 121, R8A7795_CLK_S0D6),
The above is correct for R-Car H3 ES2.0 and later.
On R-Car H3 ES1.x, the parent clock of TMU4 is S3D2 (datasheet rev 0.52),
so you need to add an entry to r8a7795es1_mod_reparent[].
> + DEF_MOD("tmu3", 122, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu2", 123, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu1", 124, R8A7795_CLK_S3D2),
> + DEF_MOD("tmu0", 125, R8A7795_CLK_CP),
> DEF_MOD("scif5", 202, R8A7795_CLK_S3D4),
> DEF_MOD("scif4", 203, R8A7795_CLK_S3D4),
> DEF_MOD("scif3", 204, R8A7795_CLK_S3D4),
The rest looks good to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
