Hi Uli,
On Tue, Dec 1, 2020 at 12:06 PM Ulrich Hecht <uli+renesas@xxxxxxxx> wrote:
> This patch adds I2C0-6 pins, groups and functions to the R8A779A0 (V3U)
> SoC.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
> ---
>
> Hi!
>
> This patch was missing from the "pinctrl: renesas: basic R8A779A0 (V3U)
> support" series. I have thus posted it on its own for review now and will
> include it in v2 of the series later.
Thanks!
> --- a/drivers/pinctrl/renesas/pfc-r8a779a0.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a779a0.c
> @@ -1199,6 +1199,70 @@ static const struct sh_pfc_pin pinmux_pins[] = {
> PINMUX_GPIO_GP_ALL(),
> };
>
> +/* - I2C0 ------------------------------------------------------------------- */
> +
Please drop this superfluous blank line.
> +static const unsigned int i2c0_pins[] = {
> + /* SDA0, SCL0 */
> + RCAR_GP_PIN(2, 3), RCAR_GP_PIN(2, 2),
> +};
> +static const unsigned int i2c0_mux[] = {
> + GP2_03_MARK, GP2_02_MARK,
If we need PINMUX_PHYS()for the I2C pins[1], then this should become:
SDA0_MARK, SCL0_MARK,
Likewise for the other I2C signals.
The rest looks good to me. so with the above corrected/clarified:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
[1] https://lore.kernel.org/linux-renesas-soc/CAMuHMdVSF_8JmR5t1aMPktY=J7=BvUbWLzPGnb9=QnRrLeA2ew@xxxxxxxxxxxxxx/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
