Hello!
On 11/24/20 2:25 PM, Lad Prabhakar wrote:
> Define rpcif_enable_rpm() and rpcif_disable_rpm() as static
Not sure why I didn't do it this way myself...
> inline in the header instead of exporting it.
s/it/them/.
> Suggested-by: Pavel Machek <pavel@xxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> drivers/memory/renesas-rpc-if.c | 13 -------------
> include/memory/renesas-rpc-if.h | 13 +++++++++++--
> 2 files changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
> index 69f2e2b4cd50..c5b5691503d7 100644
> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
[...]
> @@ -204,18 +203,6 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev)
> }
> EXPORT_SYMBOL(rpcif_sw_init);
>
> -void rpcif_enable_rpm(struct rpcif *rpc)
> -{
> - pm_runtime_enable(rpc->dev);
> -}
> -EXPORT_SYMBOL(rpcif_enable_rpm);
> -
> -void rpcif_disable_rpm(struct rpcif *rpc)
> -{
> - pm_runtime_put_sync(rpc->dev);
Ugh... sorry for this blunder (that went unnoticed till now). Mind fixing
it to pm_runtime_disable() (before this patch)?
> -}
> -EXPORT_SYMBOL(rpcif_disable_rpm);
> -
> void rpcif_hw_init(struct rpcif *rpc, bool hyperflash)
> {
> u32 dummy;
[...]
MBR, Sergei
