Hi Niklas, weird D3 should have the same but the pinmux tables do not report it.. On Wed, Nov 11, 2020 at 12:47:51AM +0100, Niklas Söderlund wrote: > This patch adds VIN{4,5}_g8 support to the R8A77990 SoC. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Looks good Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Thanks j > --- > drivers/pinctrl/renesas/pfc-r8a77990.c | 34 +++++++++++++++++++++++++- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/renesas/pfc-r8a77990.c b/drivers/pinctrl/renesas/pfc-r8a77990.c > index aed04a4c61163cb2..e2cf6061dba1b0d5 100644 > --- a/drivers/pinctrl/renesas/pfc-r8a77990.c > +++ b/drivers/pinctrl/renesas/pfc-r8a77990.c > @@ -3644,6 +3644,20 @@ static const union vin_data vin4_data_b_mux = { > }, > }; > > +static const unsigned int vin4_g8_pins[] = { > + RCAR_GP_PIN(1, 4), RCAR_GP_PIN(1, 5), > + RCAR_GP_PIN(1, 6), RCAR_GP_PIN(1, 7), > + RCAR_GP_PIN(1, 3), RCAR_GP_PIN(1, 10), > + RCAR_GP_PIN(1, 13), RCAR_GP_PIN(1, 14), > +}; > + > +static const unsigned int vin4_g8_mux[] = { > + VI4_DATA8_MARK, VI4_DATA9_MARK, > + VI4_DATA10_MARK, VI4_DATA11_MARK, > + VI4_DATA12_MARK, VI4_DATA13_MARK, > + VI4_DATA14_MARK, VI4_DATA15_MARK, > +}; > + > static const unsigned int vin4_sync_pins[] = { > /* HSYNC, VSYNC */ > RCAR_GP_PIN(2, 25), RCAR_GP_PIN(2, 24), > @@ -3718,6 +3732,20 @@ static const unsigned int vin5_data8_b_mux[] = { > VI5_DATA6_B_MARK, VI5_DATA7_B_MARK, > }; > > +static const unsigned int vin5_g8_pins[] = { > + RCAR_GP_PIN(0, 12), RCAR_GP_PIN(0, 13), > + RCAR_GP_PIN(0, 9), RCAR_GP_PIN(0, 11), > + RCAR_GP_PIN(0, 8), RCAR_GP_PIN(0, 10), > + RCAR_GP_PIN(0, 2), RCAR_GP_PIN(0, 3), > +}; > + > +static const unsigned int vin5_g8_mux[] = { > + VI5_DATA8_A_MARK, VI5_DATA9_A_MARK, > + VI5_DATA10_A_MARK, VI5_DATA11_A_MARK, > + VI5_DATA12_A_MARK, VI5_DATA13_A_MARK, > + VI5_DATA14_A_MARK, VI5_DATA15_A_MARK, > +}; > + > static const unsigned int vin5_sync_a_pins[] = { > /* HSYNC_N, VSYNC_N */ > RCAR_GP_PIN(1, 8), RCAR_GP_PIN(1, 9), > @@ -3760,7 +3788,7 @@ static const unsigned int vin5_clk_b_mux[] = { > }; > > static const struct { > - struct sh_pfc_pin_group common[247]; > + struct sh_pfc_pin_group common[249]; > struct sh_pfc_pin_group automotive[21]; > } pinmux_groups = { > .common = { > @@ -3997,6 +4025,7 @@ static const struct { > SH_PFC_PIN_GROUP(vin4_data18_b), > VIN_DATA_PIN_GROUP(vin4_data, 20, _b), > VIN_DATA_PIN_GROUP(vin4_data, 24, _b), > + SH_PFC_PIN_GROUP(vin4_g8), > SH_PFC_PIN_GROUP(vin4_sync), > SH_PFC_PIN_GROUP(vin4_field), > SH_PFC_PIN_GROUP(vin4_clkenb), > @@ -4006,6 +4035,7 @@ static const struct { > VIN_DATA_PIN_GROUP(vin5_data, 12, _a), > VIN_DATA_PIN_GROUP(vin5_data, 16, _a), > SH_PFC_PIN_GROUP(vin5_data8_b), > + SH_PFC_PIN_GROUP(vin5_g8), > SH_PFC_PIN_GROUP(vin5_sync_a), > SH_PFC_PIN_GROUP(vin5_field_a), > SH_PFC_PIN_GROUP(vin5_clkenb_a), > @@ -4439,6 +4469,7 @@ static const char * const vin4_groups[] = { > "vin4_data18_b", > "vin4_data20_b", > "vin4_data24_b", > + "vin4_g8", > "vin4_sync", > "vin4_field", > "vin4_clkenb", > @@ -4451,6 +4482,7 @@ static const char * const vin5_groups[] = { > "vin5_data12_a", > "vin5_data16_a", > "vin5_data8_b", > + "vin5_g8", > "vin5_sync_a", > "vin5_field_a", > "vin5_clkenb_a", > -- > 2.29.2 >