Re: [PATCH] arm64: dts: renesas: add sdhi/mmc aliases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shimoda-san,

CC devicetree

On Fri, Nov 6, 2020 at 10:28 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> After the commit 7320915c8861 ("mmc: Set PROBE_PREFER_ASYNCHRONOUS
> for drivers that existed in v4.14"), the order of /dev/mmcblkN
> was not fixed, so that we are hard to use the device as rootfs
> by using a kernel parameter like root=/dev/mmcblkN. So, add
> sdhi/mmc aliases.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Thanks for your patch!

> ---
>  I'm afraid, but I only tested on r8a77951-salvator-xs.
>
>  If possible, I would like to apply this patch into v5.10-stable
>  because we are hard to use the device as rootfs as I described
>  the commit description.

Please don't add aliases for various devices.
You can specify the root file system to mount using PARTUUID= or
PARTLABEL= (by the kernel), or using UUID= or LABEL= (by an initramfs).
This is the same for /dev/sd*, which may change after a kernel
upgrade.

>
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 4 ++++
>  arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 7 +++++++
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 6 ++++++
>  arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 7 +++++++
>  arch/arm64/boot/dts/renesas/r8a77951.dtsi | 4 ++++
>  arch/arm64/boot/dts/renesas/r8a77960.dtsi | 4 ++++
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 7 +++++++
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 4 ++++
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 +
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 +
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +++
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ++++
>  12 files changed, 52 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 8e80f50..9165e88 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -26,6 +26,10 @@
>                 i2c5 = &i2c5;
>                 i2c6 = &i2c6;
>                 i2c7 = &i2c_dvfs;
> +               mmc0 = &sdhi0;
> +               mmc1 = &sdhi1;
> +               mmc2 = &sdhi2;
> +               mmc3 = &sdhi3;
>         };
>
>         /*

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux