On Tue, Oct 27, 2020 at 01:40:43PM -0700, Nick Desaulniers wrote: > On Tue, Oct 27, 2020 at 1:30 PM Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote: > > > > On Tue, Oct 27, 2020 at 01:17:55PM -0700, Nick Desaulniers wrote: > > > > > (I feel the same about there > > > > > being an empty asm(); statement in the definition of asm_volatile_goto > > > > > for compiler-gcc.h). Might be time to "fix the compiler." > > > > > > > > > > (It sounds like Arvind is both in agreement with my sentiment, and has > > > > > the root cause). > > > > > > > Btw, the bug mentioned in asm_volatile_goto seems like its been fixed in > > 4.9, so the hack could be dropped now? > > https://lore.kernel.org/lkml/20180907222109.163802-1-ndesaulniers@xxxxxxxxxx/ > > For the life of me I can't find Linus' response. Maybe he shot it > down in the PR, but I can't find it...Miguel do you recall? I could > paraphrase, but might be better to not rely on my memory. > -- > Thanks, > ~Nick Desaulniers You couldn't find it in July either :) https://lkml.org/lkml/2020/7/10/1026 Possibly he didn't like the version check? That should be unnecessary now.