Hi Geert,
> Subject: Re: [PATCH 1/6] pinctrl: renesas: r8a77951: Optimize pinctrl image
> size for R8A774E1
>
> Hi Biju,
>
> On Mon, Oct 19, 2020 at 2:43 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > This driver supports both RZ/G2H and R-Car H3(R8A77951) SoC's.
> > Optimize pinctrl image size for RZ/G2H, when R-Car H3(R8A77951) SoC is
> > disabled in the defconfig.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/pinctrl/renesas/pfc-r8a77951.c
> > +++ b/drivers/pinctrl/renesas/pfc-r8a77951.c
> > @@ -1827,6 +1827,7 @@ static const unsigned int canfd1_data_mux[] = {
> > CANFD1_TX_MARK, CANFD1_RX_MARK,
> > };
> >
> > +#ifdef CONFIG_PINCTRL_PFC_R8A77951
> > /* - DRIF0
> > --------------------------------------------------------------- */ static const
> unsigned int drif0_ctrl_a_pins[] = {
> > /* CLK, SYNC */
> > @@ -2041,6 +2042,7 @@ static const unsigned int drif3_data1_b_pins[] =
> > { static const unsigned int drif3_data1_b_mux[] = {
> > RIF3_D1_B_MARK,
> > };
> > +#endif
>
> For long #ifdef blocks, where you cannot see both the #ifdef and #endif in
> your editor window, it is recommended to add comments to the #endif.
> No worries, I'll fix that myself while applying.
Thank you.
Regards,
Biju
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will
> queue in renesas-pinctrl-for-v5.11, with comments added to the #endifs
> where appropriate.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
