Hi Niklas, On Fri, Oct 16, 2020 at 12:46 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > On 2020-10-16 09:06:20 +0200, Geert Uytterhoeven wrote: > > On Fri, Oct 16, 2020 at 4:01 AM Niklas Söderlund > > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > > > This series add suspend and resume support directly to R-Car VIN and > > > indirectly to R-Car CSI-2 and other subdevices in the VIN capture > > > pipeline. The capture pipeline is stopped when suspending and started > > > when resuming, all while retaining the buffers provided from user-space. > > > This makes the start and stop of the pipeline transparent from an > > > application point of view. > > > > > > As the pipeline is switched off subdevices that poweroff themself when > > > not in use (such as R-Car CSI-2) are also switched off and are > > > indirectly serviced by the suspend support in VIN. > > > > Thanks for your series! > > > > > This work is based on-top of the media-tree and is tested on both R-Car > > > Gen2 and Gen3 without any regressions. > > > > FTR: did you test on Gen3 with both s2idle and s2ram, the latter powering > > off the SoC? > > I have only been able to test it with s2idle. My issue is that s2ram > fails to reconnect the Ethernet (ravb) and I use nfsroot. If I instead > use a initramfs I can resume from s2ram but I don't have the setup to > test capture in that environment. > [ 347.775223] libphy: ravb_mii: probed > [ 347.782808] mdio_bus e6800000.ethernet-ffffffff: MDIO device at address 0 is missing. > [ 347.794508] ravb e6800000.ethernet eth0: failed to connect PHY > [ 347.802223] PM: dpm_run_callback(): ravb_resume+0x0/0x190 returns -2 > [ 347.808739] PM: Device e6800000.ethernet failed to resume: error -2 > [ 347.929701] ata1: link resume succeeded after 1 retries > [ 347.989934] OOM killer enabled. > [ 347.993184] Restarting tasks ... done. > [ 348.004321] PM: suspend exit > [ 348.039400] ata1: SATA link down (SStatus 0 SControl 300) > [ 529.376515] nfs: server 10.0.1.1 not responding, still trying > [ 529.376702] nfs: server 10.0.1.1 not responding, still trying > [ 529.385628] nfs: server 10.0.1.1 not responding, still trying > ** Board never reaches user-space ** > > Is there a known fix for this? Please try cherry-picking commit 77972b55fb9d35d4 ("Revert "ravb: Fixed to be able to unload modules"") from v5.9. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds