Hi Geert,
On Thu, Oct 15, 2020 at 06:30:03PM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Thu, Oct 15, 2020 at 9:32 AM Jacopo Mondi <jacopo@xxxxxxxxxx> wrote:
> > On Wed, Oct 14, 2020 at 09:55:32PM +0300, Sergei Shtylyov wrote:
> > > On 10/14/20 12:44 PM, Jacopo Mondi wrote:
> > > > Add clock definitions of the VIN instances for R-Car V3U.
> > > >
> > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > > >
> > > > ---
> > > > Clocks at indexes 730 and 731 are named 'vin0' and 'vin1'.
> > > > I assumed it's a typographic error and renamed them 'vin00' and 'vin01'
Add this to the list of things which not exactly clear in the current
documentation
> > > > ---
> > > > drivers/clk/renesas/r8a779a0-cpg-mssr.c | 32 +++++++++++++++++++++++++
> > > > 1 file changed, 32 insertions(+)
> > > >
> > > > diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> > > > index bd54a28c50ee..2a00eb82013f 100644
> > > > --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> > > > +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> > > > @@ -149,6 +149,38 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
> > > > DEF_MOD("scif1", 703, R8A779A0_CLK_S1D8),
> > > > DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8),
> > > > DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8),
> > > > + DEF_MOD("vin00", 730, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin01", 731, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin02", 800, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin03", 801, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin04", 802, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin05", 803, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin06", 804, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin07", 805, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin10", 806, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin11", 807, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin12", 808, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin13", 809, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin14", 810, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin15", 811, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin16", 812, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin17", 813, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin20", 814, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin21", 815, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin22", 816, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin23", 817, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin24", 818, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin25", 819, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin26", 820, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin27", 821, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin30", 822, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin31", 823, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin32", 824, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin33", 825, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin34", 826, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin35", 827, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin36", 828, R8A779A0_CLK_S1D1),
> > > > + DEF_MOD("vin37", 829, R8A779A0_CLK_S1D1),
> >
> > > The subject says VIN[0-31]?
> >
> > There are 32 VIN instances (hence the [0-31] in the subject), grouped
> > in 4 units of 8 channels each.
> >
> > I can drop the [0-31] in the subject if it's confusing.
>
> The VIN naming in the R-Car V3U documentation is very confusing.
> E.g. all of the following are used, and refer to the same channel:
> 1. VIN37,
> 2. VIN31,
> 3. vin3 ch7.
>
> Looks good to me, but I cannot verify the parent clocks
I got them from the downstream driver, as they're not documented.
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thanks
j
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
