Re: [PATCH] clk: renesas: r8a779a0: Make rcar_r8a779a0_cpg_clk_register() static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Geert Uytterhoeven (2020-09-24 04:18:08)
> When compiling with clang:
> 
>     drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:21: warning: no previous prototype for function 'rcar_r8a779a0_cpg_clk_register' [-Wmissing-prototypes]
>     struct clk * __init rcar_r8a779a0_cpg_clk_register(struct device *dev,
>                            ^
>     drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     struct clk * __init rcar_r8a779a0_cpg_clk_register(struct device *dev,
>     ^
>     static
> 
> Similarly, with sparse:
> 
>     drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:12: warning: symbol 'rcar_r8a779a0_cpg_clk_register' was not declared. Should it be static?
> 
> There are no users of rcar_r8a779a0_cpg_clk_register() outside this
> file, so it should be static.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: c07439dea94050b6 ("clk: renesas: cpg-mssr: Add support for R-Car V3U")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux